Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated assertions #1684

Merged
merged 1 commit into from May 10, 2022

Conversation

DamnClin
Copy link
Collaborator

This should be merged only in a few versions to let user take care of
deprecated APIs

@pascalgrimaud
Copy link
Member

Thanks, I'm changing the PR to draft, so we won't merge it by mistake
I should launch the v0.4.0 today or tomorrow, so we can merge this for v0.5.0

This should be merged only in a few versions to let user take care of
deprecated APIs
@DamnClin DamnClin force-pushed the remove-deprecated-assertions branch from bb8fb5b to a42da7d Compare May 10, 2022 05:54
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1684 (a42da7d) into main (992d45e) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1684   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      1661      1649   -12     
===========================================
  Files            355       355           
  Lines           5887      5862   -25     
  Branches         145       139    -6     
===========================================
- Hits            5887      5862   -25     
Impacted Files Coverage Δ
...n/java/tech/jhipster/lite/error/domain/Assert.java 100.00% <ø> (ø)
...enerator/server/javatool/base/domain/JavaBase.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e989ba...a42da7d. Read the comment docs.

@pascalgrimaud pascalgrimaud marked this pull request as ready for review May 10, 2022 20:16
@pascalgrimaud pascalgrimaud merged commit 51f21c0 into jhipster:main May 10, 2022
@DamnClin DamnClin deleted the remove-deprecated-assertions branch May 28, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants