Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework java base module #1803

Merged
merged 1 commit into from May 23, 2022

Conversation

DamnClin
Copy link
Collaborator

Rework Java base module to use the new module mechanism

@DamnClin DamnClin marked this pull request as draft May 20, 2022 14:00
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #1803 (163161c) into main (92de65a) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1803   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1819      1842   +23     
===========================================
  Files            391       394    +3     
  Lines           6864      6916   +52     
  Branches         152       154    +2     
===========================================
+ Hits            6864      6916   +52     
Impacted Files Coverage Δ
...generator/module/domain/JHipsterProjectFolder.java 100.00% <ø> (ø)
...module/domain/InvalidProjectBaseNameException.java 100.00% <100.00%> (ø)
...e/generator/module/domain/JHipsterBasePackage.java 100.00% <100.00%> (ø)
...e/generator/module/domain/JHipsterDestination.java 100.00% <100.00%> (ø)
...e/generator/module/domain/JHipsterFileContent.java 100.00% <100.00%> (ø)
...r/lite/generator/module/domain/JHipsterModule.java 100.00% <100.00%> (ø)
...generator/module/domain/JHipsterModuleContext.java 100.00% <100.00%> (ø)
...e/generator/module/domain/JHipsterModuleFiles.java 100.00% <100.00%> (ø)
...nerator/module/domain/JHipsterProjectBaseName.java 100.00% <100.00%> (ø)
...r/lite/generator/module/domain/JHipsterSource.java 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952c00d...163161c. Read the comment docs.

@pascalgrimaud
Copy link
Member

The CI failed because the module java base didn't manage to find the template:

image

To reproduce:

  • compile to jar
  • move the jar to another folder than target folder (so it won't find template)
  • launch it with java -jar *.jar
  • use: init, maven, java base

@DamnClin
Copy link
Collaborator Author

The CI failed because the module java base didn't manage to find the template:

image

To reproduce:

* compile to jar

* move the jar to another folder than target folder (so it won't find template)

* launch it with java -jar *.jar

* use: init, maven, java base

Oh great, thx! Just a path handling thing so :D

@DamnClin DamnClin force-pushed the rework-java-base-module branch 3 times, most recently from d9dcae3 to 2f7dca6 Compare May 22, 2022 08:02
pascalgrimaud
pascalgrimaud previously approved these changes May 23, 2022
Copy link
Member

@pascalgrimaud pascalgrimaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, after that, it can be merged

@pascalgrimaud pascalgrimaud merged commit eb662a4 into jhipster:main May 23, 2022
@DamnClin DamnClin deleted the rework-java-base-module branch May 23, 2022 13:52
@DamnClin DamnClin restored the rework-java-base-module branch May 24, 2022 11:51
@DamnClin DamnClin deleted the rework-java-base-module branch May 24, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants