New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework java base module #1803
Rework java base module #1803
Conversation
src/main/java/tech/jhipster/lite/generator/module/domain/JHipsterProjectBaseName.java
Outdated
Show resolved
Hide resolved
de2188b
to
5a8d214
Compare
...ain/java/tech/jhipster/lite/generator/server/javatool/base/domain/JavaBaseModuleFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/tech/jhipster/lite/generator/server/javatool/base/domain/JavaBaseModuleFactory.java
Show resolved
Hide resolved
5a8d214
to
4a3bca3
Compare
4a3bca3
to
19ec855
Compare
Codecov Report
@@ Coverage Diff @@
## main #1803 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1819 1842 +23
===========================================
Files 391 394 +3
Lines 6864 6916 +52
Branches 152 154 +2
===========================================
+ Hits 6864 6916 +52
Continue to review full report at Codecov.
|
19ec855
to
8ce09c7
Compare
Oh great, thx! Just a path handling thing so :D |
d9dcae3
to
2f7dca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, after that, it can be merged
...ain/java/tech/jhipster/lite/generator/server/javatool/base/domain/JavaBaseModuleFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/tech/jhipster/lite/generator/server/javatool/base/domain/JavaBaseModuleFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/tech/jhipster/lite/generator/server/javatool/base/domain/JavaBaseModuleFactory.java
Outdated
Show resolved
Hide resolved
...java/tech/jhipster/lite/generator/server/javatool/base/domain/JavaBaseModuleFactoryTest.java
Outdated
Show resolved
Hide resolved
2f7dca6
to
163161c
Compare
Rework Java base module to use the new module mechanism