Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/autofill projectdetails #1876

Merged
merged 4 commits into from Jun 10, 2022
Merged

Feature/autofill projectdetails #1876

merged 4 commits into from Jun 10, 2022

Conversation

swarajsaaj
Copy link
Contributor

@swarajsaaj swarajsaaj commented May 28, 2022 •
edited

Fix #1858

@codecov
Copy link

codecov bot commented May 28, 2022 •
edited

Codecov Report

Merging #1876 (727b697) into main (e15ba93) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                main     #1876    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity      1874      2180   +306     
============================================
  Files            397       454    +57     
  Lines           7023      7935   +912     
  Branches         160       182    +22     
============================================
+ Hits            7023      7935   +912
Impacted Files Coverage Δ
...bapp/app/springboot/primary/Generator.component.ts 100.00% <100.00%> (ø)
...main/webapp/app/springboot/primary/ProjectStore.ts 100.00% <100.00%> (ø)
...bapp/app/springboot/secondary/ProjectRepository.ts 100.00% <100.00%> (ø)
...ain/webapp/app/springboot/secondary/RestProject.ts 100.00% <100.00%> (ø)
src/main/webapp/app/common/domain/Service.ts 100.00% <0.00%> (ø)
.../main/webapp/app/common/secondary/RestServiceId.ts 100.00% <0.00%> (ø)
...p/app/springboot/secondary/SpringBootRepository.ts 100.00% <0.00%> (ø)
.../springboot/primary/generator/ServiceProjection.ts 100.00% <0.00%> (ø)
...ipster/lite/common/domain/JHipsterCollections.java 100.00% <0.00%> (ø)
...r/lite/generator/module/domain/JHipsterModule.java 100.00% <0.00%> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15ba93...727b697. Read the comment docs.

pascalgrimaud
pascalgrimaud requested changes Jun 3, 2022
View reviewed changes
src/main/webapp/app/springboot/domain/ProjectService.ts Outdated
@@ -1,5 +1,6 @@
import { Project } from '@/springboot/domain/Project';
import { DocumentFile } from '@/common/domain/DocumentFile';
import { RestProject } from '../secondary/RestProject';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we are in domain, we should not import a secondary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 727b697

src/main/webapp/app/springboot/domain/ProjectService.ts Outdated
@@ -12,4 +13,5 @@ export interface ProjectService {
download(project: Project): Promise<DocumentFile>;
addCodespacesSetup(project: Project): Promise<void>;
addGitpodSetup(project: Project): Promise<void>;
getProjectDetails(folder: string): Promise<RestProject>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe return a Promise instead ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean Promise<void> instead of Promise<RestProject>?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or Promise

Copy link
Contributor Author

@swarajsaaj swarajsaaj Jun 3, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, as return type generic is not required for the feature, I have made it Promise<void> for generic required in promise.
Plus this removes the import as well

@pascalgrimaud pascalgrimaud merged commit d635329 into jhipster:main Jun 10, 2022
@swarajsaaj
Copy link
Contributor Author

bounty claimed at https://opencollective.com/generator-jhipster/expenses/81769

@pascalgrimaud
Copy link
Member

@swarajsaaj : approved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalgrimaud pascalgrimaud pascalgrimaud approved these changes

Assignees
No one assigned
Labels
area: feature request 💡 generator: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autofill of project details from path
2 participants
@swarajsaaj @pascalgrimaud