Add needle management #2132

antarus · 2022-06-16T17:52:51Z

It's a quick first draft

antarus · 2022-06-16T18:01:09Z

.../java/tech/jhipster/lite/generator/module/domain/replacement/JHipsterModuleReplacements.java

@@ -8,6 +8,7 @@

 abstract class JHipsterModuleReplacements {

+  public static final String LF = "\n";


Perhaps use System.getProperty("line.separator") ? or get from project ? instead of "\n"

I think we should "force" \n as line break everywhere, using something else is always a pain

ok but shouldn't that be set as a project property?

I think this is a mistake to use a property for that since anything else that \n will be a nightmare for the project

yes, there were several discussion about that at the beginning of this project. If we can force the use of \n for Windows too, it would be nice.

I think we can make an issue to make this on the module part so this will naturally make it's way :)

codecov · 2022-06-16T18:58:11Z

Codecov Report

Merging #2132 (cc17dee) into main (b6faf90) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2132   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2407      2425   +18     
===========================================
  Files            517       521    +4     
  Lines           8886      8929   +43     
  Branches         201       203    +2     
===========================================
+ Hits            8886      8929   +43

Impacted Files	Coverage Δ
...r/lite/generator/module/domain/JHipsterModule.java	`100.00% <100.00%> (ø)`
...domain/replacement/JHipsterModuleReplacements.java	`100.00% <100.00%> (ø)`
...generator/module/domain/replacement/JustAfter.java	`100.00% <100.00%> (ø)`
...enerator/module/domain/replacement/JustBefore.java	`100.00% <100.00%> (ø)`
...rator/module/domain/replacement/JustLineAfter.java	`100.00% <100.00%> (ø)`
...ator/module/domain/replacement/JustLineBefore.java	`100.00% <100.00%> (ø)`
...erator/module/domain/replacement/RegexMatcher.java	`100.00% <100.00%> (ø)`
...nerator/module/domain/replacement/TextMatcher.java	`100.00% <100.00%> (ø)`
src/main/webapp/app/common/domain/Service.ts	`100.00% <0.00%> (ø)`
.../main/webapp/app/common/secondary/RestServiceId.ts	`100.00% <0.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c608cd3...cc17dee. Read the comment docs.

DamnClin · 2022-06-17T05:43:08Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/JustAfter.java

+    Assert.notNull("element", element);
+  }
+  public String updateReplacement(String value) {
+    return element.searchMatcher().concat(value);


element -> element()

DamnClin · 2022-06-17T05:43:20Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/JustAfter.java

+  public JustAfter {
+    Assert.notNull("element", element);
+  }
+  public String updateReplacement(String value) {


Missing line break before method

DamnClin · 2022-06-17T05:43:35Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/JustBefore.java

+  public JustBefore {
+    Assert.notNull("element", element);
+  }
+  public String updateReplacement(String value) {


Missing line break before method

DamnClin · 2022-06-17T05:43:54Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/JustBefore.java

+    Assert.notNull("element", element);
+  }
+  public String updateReplacement(String value) {
+    return value.concat(element.searchMatcher());


element -> element()

DamnClin · 2022-06-17T05:44:18Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/JustAfter.java

+    Assert.notNull("element", element);
+  }
+  public String updateReplacement(String value) {
+    return element.searchMatcher().concat(value);


Assert.notBlank(value)

DamnClin · 2022-06-17T05:45:02Z

.../java/tech/jhipster/lite/generator/module/domain/replacement/JHipsterModuleReplacements.java

@@ -8,6 +8,7 @@

 abstract class JHipsterModuleReplacements {

+  public static final String LF = "\n";


I think we should "force" \n as line break everywhere, using something else is always a pain

DamnClin · 2022-06-17T05:45:38Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/JustAfter.java

+  public JustAfter {
+    Assert.notNull("element", element);
+  }
+  public String updateReplacement(String value) {


DamnClin · 2022-06-17T05:45:43Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/JustBefore.java

+  public JustBefore {
+    Assert.notNull("element", element);
+  }
+  public String updateReplacement(String value) {


DamnClin · 2022-06-17T05:46:00Z

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/PositionalMatcher.java

@@ -0,0 +1,7 @@
+package tech.jhipster.lite.generator.module.domain.replacement;
+
+interface PositionalMatcher {


Is it a needle matcher?

Not specifically needle, but all matcher.

src/main/java/tech/jhipster/lite/generator/module/domain/replacement/PositionalMatcher.java

DamnClin · 2022-06-21T08:48:10Z

There are some conversation left open but it's OK for me, @antarus still want to work on this?

antarus · 2022-06-21T10:04:28Z

I Can work on it but i think I made all the requests

Add needle management

9f474db

It's a quick first draft

antarus commented Jun 16, 2022

View reviewed changes

pascalgrimaud added area: enhancement 🔧 generator: internal labels Jun 17, 2022

DamnClin reviewed Jun 17, 2022

View reviewed changes

DamnClin mentioned this pull request Jun 17, 2022

Uniformise line breaks in modules #2148

Closed

Fix errors

cc17dee

antarus marked this pull request as ready for review June 20, 2022 08:44

pascalgrimaud merged commit 6ca30eb into jhipster:main Jun 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add needle management #2132

Add needle management #2132

antarus commented Jun 16, 2022

antarus Jun 16, 2022

DamnClin Jun 17, 2022

antarus Jun 17, 2022

DamnClin Jun 17, 2022

antarus Jun 17, 2022

pascalgrimaud Jun 17, 2022

DamnClin Jun 17, 2022

codecov bot commented Jun 16, 2022 •

edited

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

DamnClin Jun 17, 2022

antarus Jun 17, 2022

DamnClin commented Jun 21, 2022

antarus commented Jun 21, 2022

		@@ -8,6 +8,7 @@

		abstract class JHipsterModuleReplacements {

		public static final String LF = "\n";

		@@ -0,0 +1,7 @@
		package tech.jhipster.lite.generator.module.domain.replacement;

		interface PositionalMatcher {

Add needle management #2132

Add needle management #2132

Conversation

antarus commented Jun 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 16, 2022 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DamnClin commented Jun 21, 2022

antarus commented Jun 21, 2022

codecov bot commented Jun 16, 2022 •

edited