Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default maven goal #2194

Merged
merged 1 commit into from Jul 17, 2022
Merged

Conversation

DamnClin
Copy link
Collaborator

Just adding a default goal to avoid error when running ./mvnw

@pascalgrimaud
Copy link
Member

The only problem with this, is the user who wants to build a simple lib (init, maven, java base) without spring boot

The best solution would be:

  • when adding spring boot, add this default goal if it doesn't already exist

But I'm fine to merge this

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #2194 (4ad9d43) into main (fe1c95a) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2194   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2292      2294    +2     
===========================================
  Files            542       542           
  Lines           9280      9287    +7     
  Branches         231       231           
===========================================
+ Hits            9280      9287    +7     
Impacted Files Coverage Δ
...tor/buildtool/maven/domain/MavenModuleFactory.java 100.00% <ø> (ø)
...gboot/core/domain/SpringBootCoreModuleFactory.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1c95a...4ad9d43. Read the comment docs.

@DamnClin
Copy link
Collaborator Author

Yep, right, we can wait for spring boot migration to module and do that in a postAction then (as replacement won't check if the value is there already)

@pascalgrimaud pascalgrimaud merged commit b5c826e into jhipster:main Jul 17, 2022
@DamnClin DamnClin deleted the maven-default-goal branch October 25, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants