Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules screen #2231

Merged
merged 1 commit into from Jun 27, 2022
Merged

Modules screen #2231

merged 1 commit into from Jun 27, 2022

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented Jun 26, 2022

Related to #1565

So this is a very very simple (and ugly) implementation of the module application screen, lots of UX element are probably missing but this is usable

@DamnClin DamnClin force-pushed the modules-screen branch 2 times, most recently from 6d3dd59 to 9153090 Compare June 26, 2022 20:08
@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #2231 (ea1cf27) into main (736cf60) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2231   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2490      2490           
===========================================
  Files            539       539           
  Lines           9334      9375   +41     
  Branches         218       223    +5     
===========================================
+ Hits            9334      9375   +41     
Impacted Files Coverage Δ
...pp/app/module/primary/modules/Modules.component.ts 100.00% <100.00%> (ø)
...rc/main/webapp/app/module/primary/modules/index.ts 100.00% <100.00%> (ø)
...bapp/app/module/secondary/RestModulesRepository.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736cf60...ea1cf27. Read the comment docs.

@pascalgrimaud
Copy link
Member

Very impressive! Thanks a lot!

@DamnClin
Copy link
Collaborator Author

Very impressive! Thanks a lot!

NP :D I want to add some component test using cypress on that because the vue test utils test are not really testing anything...

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ labels Jun 27, 2022
@pascalgrimaud
Copy link
Member

I'm adding a specific bounty for this, as it's well deserved (you can claim it when it's merged)

Yes, about Cypress, indeed, we didn't add real tests so this part should be improved

@pascalgrimaud
Copy link
Member

you claim it a little bit too early but it's fine, I'm merging this :)

@pascalgrimaud pascalgrimaud merged commit bfb1b70 into jhipster:main Jun 27, 2022
@DamnClin DamnClin deleted the modules-screen branch June 27, 2022 07:08
@DamnClin
Copy link
Collaborator Author

you claim it a little bit too early but it's fine, I'm merging this :)

Oh sorry, read too fast... (was drinking coffee)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $300 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants