New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway module #2382
Gateway module #2382
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2382 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 2499 2493 -6
===========================================
Files 556 555 -1
Lines 9644 9632 -12
Branches 233 233
===========================================
- Hits 9644 9632 -12
Continue to review full report at Codecov.
|
30448fa
to
1b57ba6
Compare
seems good. Unfortunately I can't test it today. |
We spot a very probable mistake in the existing module with @pascalgrimaud in the bootsrap properties management (that were on yaml style in a properties file). This version is supposed to be better BUT I have no idea of what those properties were doing (and don't really want to take a deep look at it). @pascalgrimaud can test that easily on is current project I think :) |
Yes, I'll review and test it very soon |
Just tested it at and it works well: The API too http://localhost:8080/api/gateway/routes But we need to ignore these logs to logback, otherwise, we are spammed in the console :D <logger name="org.apache" level="ERROR" />
<logger name="reactor.netty" level="ERROR" />
<logger name="io.netty" level="ERROR" /> |
Can you resolve the conflict plz @DamnClin so it can be merged |
Close #2117