Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway module #2382

Merged
merged 1 commit into from Jul 6, 2022
Merged

Gateway module #2382

merged 1 commit into from Jul 6, 2022

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented Jul 4, 2022

Close #2117

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #2382 (22648ac) into main (df37b52) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2382   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      2499      2493    -6     
===========================================
  Files            556       555    -1     
  Lines           9644      9632   -12     
  Branches         233       233           
===========================================
- Hits            9644      9632   -12     
Impacted Files Coverage Δ
...d/common/domain/SpringCloudModuleDependencies.java 100.00% <100.00%> (ø)
...springcloud/eureka/domain/EurekaModuleFactory.java 100.00% <100.00%> (ø)
...gateway/application/GatewayApplicationService.java 100.00% <100.00%> (ø)
...ringcloud/gateway/domain/GatewayModuleFactory.java 100.00% <100.00%> (ø)
...astructure/primary/GatewayModuleConfiguration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df37b52...22648ac. Read the comment docs.

@antarus
Copy link
Contributor

antarus commented Jul 5, 2022

seems good. Unfortunately I can't test it today.

@DamnClin
Copy link
Collaborator Author

DamnClin commented Jul 5, 2022

seems good. Unfortunately I can't test it today.

We spot a very probable mistake in the existing module with @pascalgrimaud in the bootsrap properties management (that were on yaml style in a properties file). This version is supposed to be better BUT I have no idea of what those properties were doing (and don't really want to take a deep look at it). @pascalgrimaud can test that easily on is current project I think :)

@pascalgrimaud
Copy link
Member

Yes, I'll review and test it very soon

@pascalgrimaud
Copy link
Member

Just tested it at and it works well:

image

The API too http://localhost:8080/api/gateway/routes

But we need to ignore these logs to logback, otherwise, we are spammed in the console :D

  <logger name="org.apache" level="ERROR" />
  <logger name="reactor.netty" level="ERROR" />
  <logger name="io.netty" level="ERROR" />

@pascalgrimaud
Copy link
Member

Can you resolve the conflict plz @DamnClin so it can be merged

@pascalgrimaud pascalgrimaud merged commit e8ed098 into jhipster:main Jul 6, 2022
@DamnClin DamnClin deleted the gateway-module branch October 25, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert gateway to module
3 participants