Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexagonal architecture documentation improvement #3865

Merged
merged 1 commit into from Oct 8, 2022

Conversation

ptemplier
Copy link
Contributor

No description provided.

Copy link
Collaborator

@DamnClin DamnClin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -54,9 +54,9 @@ There is another **AWESOME** compilation time feedback coming not directly from

With just those two you can totally fix lots of mistakes with `firstname` and `lastname` inversions in method parameters: if you send the wrong one it just won't compile!

A little bit slower than compilation comes automated tests. As seen earlier this architecture eases testing so you'll be able to get fast (counting in seconds here) and reliable feedbacks from tests.
Then, a little bit slower than compilation, comes the use of automated tests. As seen earlier this architecture eases testing so you'll be able to get fast (counting in seconds here) and reliable feedbacks from tests.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's "comes automated tests" since we are talking about feedback loops

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e9fd1ae) compared to base (0db6884).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #3865   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2153      2153           
===========================================
  Files            564       564           
  Lines           9244      9244           
  Branches         176       176           
===========================================
  Hits            9244      9244           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ptemplier ptemplier force-pushed the patch-2 branch 2 times, most recently from 75b9380 to db8136a Compare October 8, 2022 12:35
@pascalgrimaud pascalgrimaud added the area: documentation 📚 Improvements or additions to documentation label Oct 8, 2022
@pascalgrimaud
Copy link
Member

Thanks @ptemplier :)

@pascalgrimaud pascalgrimaud merged commit 1641223 into jhipster:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📚 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants