Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International assertion errors #4565

Merged
merged 1 commit into from Dec 6, 2022

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented Dec 3, 2022

Related to #4066 and #2794

Starting an internationalization of errors for assertion errors

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (9d92e97) compared to base (f5b5d49).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #4565   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2216      2258   +42     
===========================================
  Files            590       594    +4     
  Lines           9581      9675   +94     
  Branches         187       189    +2     
===========================================
+ Hits            9581      9675   +94     
Impacted Files Coverage Δ
...jhipster/lite/error/domain/AssertionErrorType.java 100.00% <100.00%> (ø)
...jhipster/lite/error/domain/AssertionException.java 100.00% <100.00%> (ø)
...e/error/domain/MissingMandatoryValueException.java 100.00% <100.00%> (ø)
...pster/lite/error/domain/NotAfterTimeException.java 100.00% <100.00%> (ø)
...ster/lite/error/domain/NotBeforeTimeException.java 100.00% <100.00%> (ø)
...error/domain/NullElementInCollectionException.java 100.00% <100.00%> (ø)
...lite/error/domain/NumberValueTooHighException.java 100.00% <100.00%> (ø)
.../lite/error/domain/NumberValueTooLowException.java 100.00% <100.00%> (ø)
...ster/lite/error/domain/StringTooLongException.java 100.00% <100.00%> (ø)
...ter/lite/error/domain/StringTooShortException.java 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DamnClin
Copy link
Collaborator Author

DamnClin commented Dec 3, 2022

Next steps:

  • Update java-base to update the exceptions there (with attention payed to the coverage drop from new methods);
  • Create a assertion-error-handler module to add the handler with messages etc;
  • Update GeneratorException to be able to have an handler similar to this one (with additional complexity to manage keys);
  • Update java-base module to have this kind of exceptions;
  • Create a module with handler for this exceptions

@DamnClin DamnClin force-pushed the international-assertion-errors branch 2 times, most recently from 307512a to b1df52f Compare December 4, 2022 10:42
@DamnClin DamnClin force-pushed the international-assertion-errors branch from b1df52f to 9d92e97 Compare December 6, 2022 07:24
@DamnClin DamnClin merged commit 49c741e into jhipster:main Dec 6, 2022
@DamnClin DamnClin deleted the international-assertion-errors branch December 6, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant