Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'anchor points' in landscape #7854

Merged
merged 4 commits into from Nov 24, 2023

Conversation

abdelfetah18
Copy link
Contributor

Fix #3966

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8632b3) 100.00% compared to head (fd4f7df) 100.00%.
Report is 174 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #7854   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2665      2665           
===========================================
  Files            681       683    +2     
  Lines          11668     11720   +52     
  Branches         250       256    +6     
===========================================
+ Hits           11668     11720   +52     
Files Coverage Δ
...pp/module/primary/landscape/Landscape.component.ts 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pascalgrimaud
Copy link
Member

can you resolve current conflict in this branch plz @abdelfetah18 ?

@Gnuk : any chance you have a quick look on this plz?

@pascalgrimaud pascalgrimaud merged commit a4aab16 into jhipster:main Nov 24, 2023
32 checks passed
@pascalgrimaud
Copy link
Member

Thanks @abdelfetah18 for your work and your patience

@abdelfetah18
Copy link
Contributor Author

Thanks @abdelfetah18 for your work and your patience

You're very welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "anchor points" in landscape
3 participants