Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress react #786

Merged
merged 10 commits into from Apr 2, 2022
Merged

Add cypress react #786

merged 10 commits into from Apr 2, 2022

Conversation

flcarre
Copy link
Contributor

@flcarre flcarre commented Feb 21, 2022

fix #776

POST /api/vite/react
POST /api/vite/react/cypress
npm install
npm run cypress:open
npm run cypress:run

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #786 (e382257) into main (3d10562) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main      #786   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1467      1486   +19     
===========================================
  Files            277       282    +5     
  Lines           4757      4807   +50     
  Branches          88        88           
===========================================
+ Hits            4757      4807   +50     
Impacted Files Coverage Δ
...lite/generator/client/react/core/domain/React.java 100.00% <100.00%> (ø)
...ss/application/CypressReactApplicationService.java 100.00% <100.00%> (ø)
...ator/client/react/cypress/domain/CypressReact.java 100.00% <100.00%> (ø)
...eact/cypress/domain/CypressReactDomainService.java 100.00% <100.00%> (ø)
...tructure/config/CypressReactBeanConfiguration.java 100.00% <100.00%> (ø)
...s/infrastructure/primary/CypressReactResource.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d10562...e382257. Read the comment docs.

@flcarre
Copy link
Contributor Author

flcarre commented Feb 21, 2022

@pascalgrimaud can't assigne reviewers but need one

@pascalgrimaud
Copy link
Member

@flcarre : can't you ?

image

@flcarre
Copy link
Contributor Author

flcarre commented Feb 21, 2022

nope i can't

@pascalgrimaud
Copy link
Member

@flcarre : can you rebase plz?

@pascalgrimaud
Copy link
Member

Just tried it, and it doesn't work:

I started the project:

./mvnw spring-boot:run

I launch:

npm run cypress:run

image

@flcarre
Copy link
Contributor Author

flcarre commented Mar 3, 2022

work for me, have you init the react project with /api/vite/react ? The cypress api just add cypress to an existing react project
image

@pascalgrimaud
Copy link
Member

Yes, I did it in a generated project: reactapp
I think it's because Cypress launch test in localhost:3000 instead of localhost:{{serverPort}}
The default backend is localhost:8080

@pascalgrimaud pascalgrimaud marked this pull request as draft March 10, 2022 14:21
@pascalgrimaud
Copy link
Member

@flcarre : I'm taking care of this

  • update the branch with last change in main
  • fixing merge conflicts
  • fixing the last code smells
  • clean some code
  • merge it
  • so @Bolo89 can refactorize this part to make it common with Vue

@pascalgrimaud pascalgrimaud marked this pull request as ready for review April 2, 2022 09:03
@pascalgrimaud pascalgrimaud merged commit f513eb4 into jhipster:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React: add cypress
2 participants