Rework Spring properties comments and generates comments in YAML configuration #8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was confusing and not working exactly as intended. We can do something similar with the simple comment on a (partial) key.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8092 +/- ##
============================================
Coverage 100.00% 100.00%
+ Complexity 2665 2619 -46
============================================
Files 683 680 -3
Lines 11695 11563 -132
Branches 250 246 -4
============================================
- Hits 11695 11563 -132 ☔ View full report in Codecov by Sentry. |
murdos
force-pushed
the
preserve-existing-yaml-comment
branch
from
6bdf34c
to
26c1ef2
Compare
murdos
force-pushed
the
preserve-existing-yaml-comment
branch
from
26c1ef2
to
c80ac17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7939