add webjars (locator) modules #8226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomfrede
force-pushed
the
add-webjars-module
branch
from
7f2815d
to
268e258
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8226 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2625 2632 +7
===========================================
Files 683 686 +3
Lines 11618 11642 +24
Branches 253 253
===========================================
+ Hits 11618 11642 +24 ☔ View full report in Codecov by Sentry. |
murdos
approved these changes
Dec 3, 2023
murdos
added
area: feature request 💡
server: spring boot
server: java
and removed
area: triage
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional webjars module, which adds the webjars locator dependency, such that one can use webjars. This prepares additional webjar modules (e.g. htmx, alpine.js) for server side frontend rendering.
In addition this enhances the thymeleaf module to also add the thymeleaf layout dialect, which enables reuseable, common layouts with thymeleaf (imho this a must when using thymeleaf for more than hello world). See https://github.com/ultraq/thymeleaf-layout-dialect for details.
updates #4339