Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add htmx webjars module #8229

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

atomfrede
Copy link
Member

Moving the webjars module to webjars-locator, adding a htmx-webjars module.

updates #4339

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8577f79) 100.00% compared to head (8362ea2) 100.00%.
Report is 130 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #8229   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2632      2638    +6     
===========================================
  Files            686       686           
  Lines          11642     11677   +35     
  Branches         253       253           
===========================================
+ Hits           11642     11677   +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pascalgrimaud
Copy link
Member

maybe adding a test in the CI ?
see https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh

@atomfrede
Copy link
Member Author

Yes good point.

@atomfrede
Copy link
Member Author

maybe adding a test in the CI ? see https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh

Added the webjars part to the thymeleaf ci sample

murdos
murdos previously approved these changes Dec 6, 2023
@pascalgrimaud
Copy link
Member

thanks @atomfrede : is it ready to be merged for the next release?

@atomfrede
Copy link
Member Author

Yes, I don't see any issues with the current feature set. The next part will be more tricky I suppose, adding the webjars to the thymeleaf skeleton page.

@pascalgrimaud pascalgrimaud merged commit c20e241 into jhipster:main Dec 7, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants