-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add htmx webjars module #8229
add htmx webjars module #8229
Conversation
6a5d0e9
to
d1bb7d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8229 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2632 2638 +6
===========================================
Files 686 686
Lines 11642 11677 +35
Branches 253 253
===========================================
+ Hits 11642 11677 +35 ☔ View full report in Codecov by Sentry. |
maybe adding a test in the CI ? |
Yes good point. |
...ster/lite/generator/server/webjars/locator/application/WebjarsLocatorApplicationService.java
Outdated
Show resolved
Hide resolved
Added the webjars part to the thymeleaf ci sample |
thanks @atomfrede : is it ready to be merged for the next release? |
Yes, I don't see any issues with the current feature set. The next part will be more tricky I suppose, adding the webjars to the thymeleaf skeleton page. |
Moving the webjars module to webjars-locator, adding a htmx-webjars module.
updates #4339