Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitinfo nature: it's a shared kernel, not a business context #8296

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Dec 6, 2023

No description provided.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64fdf2) 100.00% compared to head (a10b4bb) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #8296   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2632      2632           
===========================================
  Files            686       686           
  Lines          11642     11642           
  Branches         253       253           
===========================================
  Hits           11642     11642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pascalgrimaud
Copy link
Member

By nature, agree it should be shared kernel. But like this, it won't be used somewhere else, as there is only 1 single configuration class.
Do you have something in mind?

@murdos
Copy link
Contributor Author

murdos commented Dec 6, 2023

By nature, agree it should be shared kernel. But like this, it won't be used somewhere else, as there is only 1 single configuration class. Do you have something in mind?

At work I'm generating living documentation using these annotations (including a context map using https://contextmapper.org/), and this package pops as a business context with the other real business contexts whereas it should not.

I agree that everything within the wire package is most of the time not a shared kernel: would you suggest to rather remove the package-info.java?

@pascalgrimaud pascalgrimaud merged commit f35e266 into main Dec 6, 2023
36 checks passed
@pascalgrimaud pascalgrimaud deleted the gitinfo-shared-kernel branch December 6, 2023 20:23
@pascalgrimaud
Copy link
Member

No, I was curious :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants