Group maven/gradle wrappers as 'build-launcher' and add dependencies

[gzsombor]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e28df1e) 100.00% compared to head (220f65a) 100.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##                main     #8694   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2821      2821           
===========================================
  Files            719       719           
  Lines          12404     12405    +1     
  Branches         250       250           
===========================================
+ Hits           12404     12405    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[murdos]

How about "java-build-tool-wrapper"?
I'm not sure that "build-launcher" is meaningful.

[gzsombor]

That could work as well 😄

[pascalgrimaud]

Not sure about this change, as maven-java already added the maven-wrapper

I add this module as standalone for 2 reasons:

• to add this wrapper on existing projects which were not generated with JHLite
• to sometimes upgrade wrapper

So I think it should stay as standalone and not depend on other module

[gzsombor]

Yes, I've just noticed, that the maven wrapper is still installed. I would rather remove it from when MAVEN_JAVA is applied. Currently I'm trying to create a more modern project setup, with a declarative version and environment manager like mise/rtx/asdf, so these wrapper executables are very misleading in my project setup.

[pascalgrimaud]

Yes it could be possible to remove it from the maven_java, but in this case, it should be rename to maven_pom_xml_java

I would suggest to open a new ticket to discuss about what we should do for this maven-wrapper, because with this change, this module becomes useless :-p

[pascalgrimaud]

And renaming module is a small breaking change for existing projects

[murdos]

Yes it could be possible to remove it from the maven_java, but in this case, it should be rename to maven_pom_xml_java

Sorry, I did not notice this issue before merging the PR...

I would also remove the maven wrapper from the maven_java module, I often encounter projects that use maven but don't need the maven wrapper. BTW I just verified: the gradle module also generates the wrapper, but I think I just did that to mimic the maven behavior. I was persuaded that gradle wrapper was an opt-in option by using the gradle-wrapper module.

However I don't think we should rename "maven_java", event if we remove the wrapper: even if there's just a pom.xml generated it's a building block of all other modules, and marks the choice of the java build tool.
I don't think you would want to rename the gradle_java module to "gradle_build.gradle_settings_gradle_libs_versions_java" (corresponding to the 3 generated files for gradle: build.gradle.kts, settings.gradle.kts and gradle/libs.versions.toml)

[gzsombor]

I've opened a ticket about this #8697 for further discussions