Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jhlite dependency to 1.3.0 #8760

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Bump jhlite dependency to 1.3.0 #8760

merged 1 commit into from
Jan 27, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Jan 27, 2024

No description provided.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2716e1b) 100.00% compared to head (0430fa6) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #8760   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2819      2819           
===========================================
  Files            719       719           
  Lines          12410     12410           
  Branches         250       250           
===========================================
  Hits           12410     12410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murdos murdos merged commit 4cf8ae6 into jhipster:main Jan 27, 2024
38 checks passed
@pascalgrimaud
Copy link
Member

The main problem is:

  • when generating jhlite custom, it will use the previous release instead of the last one
  • in the CI, we can't use the last release as it doesn't exist yet

I don't know how we could solve it. Any idea?

@murdos murdos deleted the update-jhlite branch January 28, 2024 19:48
@murdos
Copy link
Contributor Author

murdos commented Jan 28, 2024

@pascalgrimaud : I thought a bit about it, and I think we might solve that by:

  • using maven resources filtering to replace jhlite version in src/main/resources/generator/dependencies/pom.xml by current jhlite version, using ${project.version} => that way custom-jhlite will always use the version of jhlite it has been generated with
  • in CI, for custom-jhlite tests, extract the jhlite version required by custom-jhlite, and install in the maven local repository the jhlite-jar with the extracted version. mvn install:install-file -Dfile=jhlite.jar -DgroupId=tech.jhipster.lite -DartifactId=jhlite -Dversion=<extracted-version>

WDYT?

@pascalgrimaud
Copy link
Member

Yes sound good
For th CI, we could use snapshot version too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants