Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17: Update angular.json #8762

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jan 28, 2024

Fix #8761

Before
image

After
image

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4cf8ae6) 100.00% compared to head (aaacd5f) 100.00%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #8762   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2819      2819           
===========================================
  Files            719       719           
  Lines          12410     12409    -1     
  Branches         250       250           
===========================================
- Hits           12410     12409    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -25,7 +25,7 @@
"output": "content"
}
],
"styles": ["src/main/webapp/styles.css"],
"styles": ["src/main/webapp/styles.css", "@angular/material/prebuilt-themes/indigo-pink.css"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we should add by default in angular core something related to material ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, forget my comment, angular core add material by default, so it's ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

@pascalgrimaud pascalgrimaud merged commit e666956 into jhipster:main Jan 29, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 17: Update angular.json
2 participants