Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JaCoCo configuration to check minimum coverage #8776

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Jan 29, 2024

This will help checking coverage locally when developing jhlite: a first feedback without the need to wait for CI build and Codecov report.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (524bbf0) to head (730cb6c).

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #8776   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2903      2903           
===========================================
  Files            733       733           
  Lines          12527     12527           
  Branches         253       253           
===========================================
  Hits           12527     12527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murdos
Copy link
Contributor Author

murdos commented Feb 26, 2024

After more investigation, some tests are only ran on Linux, using @EnabledOnOs(OS.LINUX), that's why the build fails on Windows.
I'm inclined to move this specific jacoco configuration to a maven profile that would be activate only for Linux.

@renanfranca
Copy link
Contributor

@murdos : I checked out this pull request branch, ran the command ./mvnw verify, and failed. It should pass, isn't it? Am I doing something wrong?

image
image

image
image

@murdos
Copy link
Contributor Author

murdos commented Feb 29, 2024

@murdos : I checked out this pull request branch, ran the command ./mvnw verify, and failed. It should pass, isn't it? Am I doing something wrong?

Hmm... it works fine for me, and in CI... Maybe try to clean before, to be sure: ./mvnw clean verify

Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! 👍

@murdos murdos merged commit bdb010e into jhipster:main Feb 29, 2024
37 checks passed
@murdos murdos deleted the jacoco-coverage branch February 29, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants