replace default server port when property has custom value

[alerGeek]

PR fix frontend properties:

• replace default value (8080) for Angular Module
• replace default value (8080) for React Module
• replace default value (8080) for ThymeLeaf Module

PR fix README.md files/properties for ouath docker image.

Fix #8824

[CLAassistant]

All committers have signed the CLA.

[murdos]

Thanks for the PR!
I made a few suggestions to simplify things

[murdos]

There's no reason to redefine the default 8080 port in every module, it's already defined in JHipsterServerPort so you can just use:

Suggested change

	.addScript(scriptKey("watch:serve"), scriptCommand("browser-sync start --no-inject-changes --proxy localhost:%s --files 'target/classes/templates' 'target/classes/static'".formatted(getServerPort(properties))))
	.addScript(scriptKey("watch:serve"), scriptCommand("browser-sync start --no-inject-changes --proxy localhost:%s --files 'target/classes/templates' 'target/classes/static'".formatted(properties.serverPort().get())))

and remove the getServerPort() method below.

[alerGeek]

Thanks! I was not sure if the serverPort property is generated as well when no spring-boot-mvc-empty module is added. I have removed unnecessary method

[murdos]

Rather than doing a replacement, you should turn proxy.conf.json to a template that will use the serverPort properties:

• rename proxy.conf.json in src/main/resources/generator/client/angular/core/ to proxy.conf.json.mustache and replace 8080 by {{serverPort}}
• change line .add(SOURCE.file("proxy.conf.json"), to("proxy.conf.json")) to .addTemplate(SOURCE.file("proxy.conf.json"), to("proxy.conf.json"))

[alerGeek]

Done. I have did the same to vte.config.ts in React Module. However, as I was not able to add the addTemple without the batch, I had to modify it to:

...
        .batch(SOURCE, to("."))
          .addTemplate("proxy.conf.json")
          .and()
...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f0e8ca) 100.00% compared to head (f6d69a3) 100.00%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##                main     #8825   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2819      2819           
===========================================
  Files            719       719           
  Lines          12409     12411    +2     
  Branches         250       250           
===========================================
+ Hits           12409     12411    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[murdos]

Congrats @alerGeek for your first contribution :-)