(ci) Introduce java-build-tool in build matrix #8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8986 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2899 2899
===========================================
Files 733 733
Lines 12514 12514
Branches 254 254
===========================================
Hits 12514 12514 ☔ View full report in Codecov by Sentry. |
renanfranca
reviewed
Feb 23, 2024
Comment on lines
-323
to
+326
| ./generate.sh ${{ matrix.app }} ${{ matrix.spring-config-format }} | ||
| ./generate.sh ${{ matrix.app }} ${{ matrix.java-build-tool }} ${{ matrix.spring-config-format }} |
There was a problem hiding this comment.
Should this change need to be done at the following step too?
- name: 'Generation: generate ${{ matrix.app }} from main branch'
if: github.event_name == 'pull_request'
working-directory: ./main-branch/tests-ci/
run: |
./start.sh 7471
./generate.sh ${{ matrix.app }} ${{ matrix.spring-config-format }}
./stop.shThere was a problem hiding this comment.
I thought about it, but I came to the conclusion that this change should be made once this PR is merged, because script of main branch still uses 2 input parameters.
There was a problem hiding this comment.
Ohh! That's true, thank you for this great improvement 👍
This was referenced Feb 27, 2024
Closed
…tion
This will help testing more easily different gradle application.
And this will solve the issue of applying a feature rather than a module: since we can't apply through JHipster REST API a feature 'github-actions' that regroups either 'github-actions-maven' or 'github-actions-gradle', we can either have bash function that return the right module for the java-build-tool or use expression like 'github-actions-${java_build_tool}'
murdos
force-pushed
the
ci/java-build-tool-matrix
branch
from
48194d5
to
29998ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows better handling of build cache, and this will help testing more easily different gradle applications.
This will also solve the issue of applying a feature rather than a module: since we can't apply through JHipster REST API a feature 'github-actions' that regroups either 'github-actions-maven' or 'github-actions-gradle', we can either have bash function that return the right module for the java-build-tool or use expression like 'github-actions-${java_build_tool}'