Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup commands improvements #9025

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Feb 25, 2024

No description provided.

…ine and GradleStartupCommandLine

It should be the responsibility of  MavenStartupCommandLine and GradleStartupCommandLine to add it
@renanfranca
Copy link
Contributor

Thanks, Interesting improvements! I am going to take a closer look as it is an opportunity to learn 😊

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5eeaf7b) to head (88db277).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #9025   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2880      2887    +7     
===========================================
  Files            729       731    +2     
  Lines          12514     12512    -2     
  Branches         256       256           
===========================================
- Hits           12514     12512    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

renanfranca
renanfranca previously approved these changes Feb 26, 2024
Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murdos : Thank you very much! 💙

This new switch features makes me want to use the interfaces instead of enums. There was a lot of stuffs going on at the interface StartupCommand:

  • including the possibility to use supresswarning for sonar
  • more than one "public" records in the same file which makes sense for me, but sometimes it isn't considere best practices by my co-works

I am going to use this approach at my next issue #8963 !

@murdos
Copy link
Contributor Author

murdos commented Feb 26, 2024

@renanfranca : thanks for the feedback! I've moved all implementations of StartupCommand to their own top-level file :)

@murdos murdos merged commit e647659 into jhipster:main Feb 26, 2024
37 checks passed
@renanfranca
Copy link
Contributor

renanfranca commented Feb 26, 2024

@renanfranca : thanks for the feedback! I've moved all implementations of StartupCommand to their own top-level file :)

Nice! You are welcome 👍😁

@murdos murdos deleted the enh/startup-commands branch March 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants