-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Startup commands improvements #9025
Conversation
…ine and GradleStartupCommandLine It should be the responsibility of MavenStartupCommandLine and GradleStartupCommandLine to add it
…g docker compose file is enough
Thanks, Interesting improvements! I am going to take a closer look as it is an opportunity to learn 😊 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9025 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2880 2887 +7
===========================================
Files 729 731 +2
Lines 12514 12512 -2
Branches 256 256
===========================================
- Hits 12514 12512 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@murdos : Thank you very much! 💙
This new switch features makes me want to use the interfaces instead of enums. There was a lot of stuffs going on at the interface StartupCommand:
- including the possibility to use supresswarning for sonar
- more than one "public" records in the same file which makes sense for me, but sometimes it isn't considere best practices by my co-works
I am going to use this approach at my next issue #8963 !
@renanfranca : thanks for the feedback! I've moved all implementations of StartupCommand to their own top-level file :) |
Nice! You are welcome 👍😁 |
No description provided.