Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar: %n should be used in place of \n to produce the platform-specific line separator. #9090

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7513cfa) to head (4b5a0f0).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #9090   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      2920      2918    -2     
===========================================
  Files            733       733           
  Lines          12616     12611    -5     
  Branches         254       254           
===========================================
- Hits           12616     12611    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qmonmert qmonmert force-pushed the codesmell29022024 branch 2 times, most recently from 631c1e9 to f201415 Compare March 2, 2024 17:12
@qmonmert
Copy link
Contributor Author

qmonmert commented Mar 2, 2024

@murdos \\n are really necessary in the regex because tests are ✅ without?

@murdos
Copy link
Contributor

murdos commented Mar 2, 2024

@murdos \\n are really necessary in the regex because tests are ✅ without?

@qmonmert : Good point. I was not aware until now, but \s match return line \n, so line separator is indeed not necessary.
I've pushed to your branch a modification of an existing test using a dependency with multiple exclusions, to be sure that this case is covered.

So +1 for removing the line separator :-)

@qmonmert qmonmert marked this pull request as ready for review March 2, 2024 18:40
@qmonmert
Copy link
Contributor Author

qmonmert commented Mar 2, 2024

@murdos seems good

@murdos murdos merged commit 554d773 into jhipster:main Mar 2, 2024
37 checks passed
@murdos
Copy link
Contributor

murdos commented Mar 2, 2024

Thanks @qmonmert ! 🙂

@qmonmert
Copy link
Contributor Author

qmonmert commented Mar 2, 2024

@murdos @pascalgrimaud
https://sonarcloud.io/summary/overall?id=jhipster_jhipster-lite
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants