Rename "dummy" feature to "sample" feature #9098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Sample' is more explicit than 'dummy'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9098 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2918 2918
===========================================
Files 733 733
Lines 12611 12612 +1
Branches 254 254
===========================================
+ Hits 12611 12612 +1 ☔ View full report in Codecov by Sentry. |
…od parameter names should comply with a naming convention
|
I think this project https://github.com/jhipster/jhipster-lite-sample-app needs to be updated too, @murdos ? |
murdos
added a commit
to murdos/jhipster-lite-sample-app
that referenced
this pull request
Mar 3, 2024
|
@pascalgrimaud : Right! Done 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7728: using "sample" is much clearer than using "dummy" for generated sample code