Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make npm tasks cachable again via gradle enterprise plugin #9239

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

atomfrede
Copy link
Member

After setting the installDirectory property the npm tasks became not cachable (as it is a file). We don't cache the node/npm installation so we can safely ignore it for the cacheable confiuration for npm install, npm build and npm tests.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e6e29e5) to head (b413f42).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #9239   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2940      2940           
===========================================
  Files            734       734           
  Lines          12681     12681           
  Branches         257       257           
===========================================
  Hits           12681     12681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murdos
Copy link
Contributor

murdos commented Mar 16, 2024

Thanks @atomfrede !
Is this a side effect of #9099? I guess we should now be careful when we change configuration of plugins, or id of executions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants