Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maven-failsafe-plugin double execution #9241

Merged

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Mar 16, 2024

Parent project (spring-boot-starter-parent) already defines a "default" execution for maven-failsafe-plugin with goals integration-test and verify.
By redefining 2 additional executions, each goal is executed twice.

image

image

Parent project (spring-boot-parent) already defines a "default" execution for maven-failsafe-plugin with goals integration-test and verify
By redefining 2 additional executions, each goal is executed twice
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7ff55b2) to head (104479b).

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #9241   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2940      2940           
===========================================
  Files            734       734           
  Lines          12681     12681           
  Branches         257       257           
===========================================
  Hits           12681     12681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atomfrede
Copy link
Member

Awesome! Did notice that in the build scans but did not investigate further.

@murdos murdos merged commit 30c5d07 into jhipster:main Mar 16, 2024
38 checks passed
@murdos murdos deleted the fix/remove-double-integration-tests-execution branch March 16, 2024 19:10
@murdos
Copy link
Contributor Author

murdos commented Mar 16, 2024

I also noticed it from build scans 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants