Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax minimum node and maven versions required to contribute to jhipster-lite #9407

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Mar 31, 2024

IMO we should not require latest version of development tools: it can be a barrier for new contributors.

As an example, my linux distribution doesn't yet provide node 20.12.0 (whereas I'm using a rolling update distribution that provides recent versions).

Latest version might not be available right away on all Linux distributions
…ithub-action

The latest will be automatically picked
This is the version used in the last Ubuntu LTS (22.04)
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (734761d) to head (8b3cab7).

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #9407   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2959      2959           
===========================================
  Files            737       737           
  Lines          12819     12819           
  Branches         259       259           
===========================================
  Hits           12819     12819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murdos murdos merged commit 206791b into jhipster:main Apr 3, 2024
38 checks passed
@murdos murdos deleted the relax-node-and-mvn-versions branch April 3, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants