Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develocity: replace deprecated "GRADLE_ENTERPRISE_ACCESS_KEY" environment variable by "DEVELOCITY_ACCESS_KEY" #9610

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Apr 22, 2024

Following #9596

Fix warning:
image

@murdos murdos requested a review from atomfrede April 22, 2024 20:36
@murdos murdos changed the title Develocity: replace deprecated "GRADLE_ENTERPRISE_ACCESS_KEY" environ… Develocity: replace deprecated "GRADLE_ENTERPRISE_ACCESS_KEY" environment variable by "DEVELOCITY_ACCESS_KEY" Apr 22, 2024
@@ -115,7 +115,7 @@ jobs:
run: sed -i '/- gradle-java/d' src/main/resources/config/application.yml
- name: 'Test: run backend tests'
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
DEVELOCITY_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pascalgrimaud : we should probably also rename the secret from GRADLE_ENTERPRISE_ACCESS_KEY to DEVELOCITY_ACCESS_KEY

@murdos murdos merged commit 5c24838 into jhipster:main Apr 23, 2024
36 checks passed
@murdos murdos deleted the develocity-migration branch April 23, 2024 21:30
@pascalgrimaud
Copy link
Member

@murdos : just added you as admin of this repository

I don't know the original value of GRADLE_ENTERPRISE_ACCESS_KEY to change it :-)

@atomfrede
Copy link
Member

I know the original value :)

@pascalgrimaud
Copy link
Member

@atomfrede : added you as admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants