-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonar: Fix tag em with role=img #9632
Conversation
@pascalgrimaud an idea for the build failed? :) |
I think we need to add the new key related to gradle. Waiting @murdos or @atomfrede |
ok |
I'm not sure it's related to develocity, since other builds look fine, and there's also another error:
@qmonmert: I'm gonna add temporarily commits to your branch to check if it's related, I'll then revert them. |
The issue is reproducible locally if you try to build the docker image from this branch.
|
@qmonmert : you should try to rebase your branch 🙂 |
@murdos done but it doesn't work :/ |
3e42a19
to
76e4f12
Compare
@qmonmert : I rebased the branch, and merged the PR since the build was green :) |
@murdos thanks what was the problem? @pascalgrimaud quality ✅ |
Fix https://sonarcloud.io/project/issues?impactSoftwareQualities=MAINTAINABILITY&resolved=false&id=jhipster_jhipster-lite&open=AY8KyTGBADMkkF4M9RVl&tab=code