Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar: Fix tag em with role=img #9632

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

@qmonmert
Copy link
Contributor Author

@pascalgrimaud an idea for the build failed? :)

@pascalgrimaud
Copy link
Member

I think we need to add the new key related to gradle. Waiting @murdos or @atomfrede

@qmonmert
Copy link
Contributor Author

ok

@qmonmert qmonmert marked this pull request as draft April 24, 2024 19:28
@murdos
Copy link
Contributor

murdos commented Apr 24, 2024

I'm not sure it's related to develocity, since other builds look fine, and there's also another error:

9 21.87 [INFO] --- frontend:1.15.0:npm (build front) @ jhlite ---
#9 21.92 [INFO] npm not inheriting proxy config from Maven
#9 21.92 [INFO] Running 'npm run build' in /code/jhipster-app
#9 22.23 [INFO]
#9 22.23 [INFO] > jhlite@1.7.1-SNAPSHOT build
#9 22.23 [INFO] > vue-tsc -p tsconfig.build.json --noEmit && vite build --emptyOutDir && tikui-core build
#9 22.23 [INFO]
#9 22.24 [INFO] sh: 1: vue-tsc: not found

@qmonmert: I'm gonna add temporarily commits to your branch to check if it's related, I'll then revert them.

@murdos
Copy link
Contributor

murdos commented Apr 24, 2024

The issue is reproducible locally if you try to build the docker image from this branch.
It think the problem comes from the build cache that is corrupted:

#9 21.14 [INFO] --- frontend:1.15.0:npm (npm install) @ jhlite ---
#9 21.86 [INFO] Loaded from the build cache, saving 0.769s

root@a0c996edfa73:/code/jhipster-app# ls node_modules/vue-tsc/bin/
root@a0c996edfa73:/code/jhipster-app#

@murdos
Copy link
Contributor

murdos commented Apr 25, 2024

@qmonmert : you should try to rebase your branch 🙂

@qmonmert
Copy link
Contributor Author

@murdos done but it doesn't work :/

@murdos murdos marked this pull request as ready for review April 28, 2024 09:15
@murdos murdos merged commit 178effa into jhipster:main Apr 28, 2024
35 checks passed
@murdos
Copy link
Contributor

murdos commented Apr 28, 2024

@qmonmert : I rebased the branch, and merged the PR since the build was green :)

@qmonmert
Copy link
Contributor Author

@murdos thanks what was the problem?

@pascalgrimaud quality ✅
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants