Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing frontend server plugin #9825

Merged
merged 15 commits into from
May 18, 2024
Merged

add missing frontend server plugin #9825

merged 15 commits into from
May 18, 2024

Conversation

renanfranca
Copy link
Contributor

@renanfranca renanfranca commented May 16, 2024 •
edited
Loading

Fix #9743

@renanfranca renanfranca self-assigned this May 16, 2024
@renanfranca renanfranca force-pushed the 9743-add-missing-frontend-server-plugin branch from 6a5ce0c to e77a812 Compare May 16, 2024 15:15
@renanfranca
add gradle frontend server plugin
ad86458
@renanfranca
move the jhipster-needle-gradle-properties right after plugins declar…
cad7efa 
…ation

Because the properties variable must be declared before the place which use it
@renanfranca
refactor by remove code duplication
f53dabd
@renanfranca
group frontend-maven-plugin and frontend-gradle-plugin modules with f…
f13b9b8 
…rontend-server-plugin feature
@renanfranca
add maven-java module as dependency for frontend-maven-plugin and add…
7880700 
… gradle-java module as dependency for frontend-gradle-plugin
@renanfranca
fix node version property variable name
1ceff9a
@renanfranca
add instruction at the end of tasks.Test at build.gradle.kts
f0954bd
@renanfranca
refactor test to make it easier to identify which configuration block…
d068054 
… is not right
@renanfranca
set testNpm task to explicit run test coverage
e1a73ef
@renanfranca renanfranca force-pushed the 9743-add-missing-frontend-server-plugin branch from 89c9968 to e1a73ef Compare May 17, 2024 13:19
@renanfranca renanfranca mentioned this pull request May 17, 2024
Closed
4 tasks
@renanfranca renanfranca marked this pull request as ready for review May 17, 2024 15:56
@renanfranca renanfranca requested a review from murdos May 17, 2024 15:56
@renanfranca renanfranca requested a review from murdos May 18, 2024 10:11
@murdos murdos merged commit f0f10aa into jhipster:main May 18, 2024
35 checks passed
@murdos
Copy link
Contributor

murdos commented May 18, 2024

Thanks for your work! 🙂

@renanfranca
Copy link
Contributor Author

Thanks for your work! 🙂

Yeahhh! That was huge!!! Thanks!

@murdos
Copy link
Contributor

murdos commented May 18, 2024

That was huge!!!

Absolutely! I've talked with @pascalgrimaud, the current bounty will be increased, because it was more work than expected 😉

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels May 19, 2024
@pascalgrimaud
Copy link
Member

Added a bounty, you can claim it, @renanfranca

@renanfranca renanfranca deleted the 9743-add-missing-frontend-server-plugin branch May 20, 2024 11:33
@renanfranca
Copy link
Contributor Author

@pascalgrimaud: Bounty Claimed https://opencollective.com/generator-jhipster/expenses/203321. Thanks 😄 ✌

@pascalgrimaud
Copy link
Member

@renanfranca : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murdos murdos murdos approved these changes

Assignees

@renanfranca renanfranca

Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: gradle $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing gradle frontend server plugin
3 participants
@renanfranca @murdos @pascalgrimaud