safely remove property version when removing dependency #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
changed the title
renanfranca
force-pushed
the
6977-maven-safety-remove-property-version-when-removing-dependency
branch
from
fc5bab1
to
ad82b67
Compare
renanfranca
changed the title
@murdos : I generated a |
murdos
reviewed
Jun 4, 2024
.../jhipster/lite/module/infrastructure/secondary/javadependency/maven/MavenCommandHandler.java
Outdated
Show resolved
Hide resolved
.../jhipster/lite/module/infrastructure/secondary/javadependency/maven/MavenCommandHandler.java
Outdated
Show resolved
Hide resolved
| Collection<JavaBuildCommand> versionCommands( | ||
| JavaDependenciesVersions currentVersions, | ||
| ProjectJavaDependencies projectDependencies, | ||
| Collection<JavaBuildCommand> dependencyCommands |
There was a problem hiding this comment.
If find that signature a bit strange... to generate version commands, you need other commands.
Out of curiosity, have you thought about an alternative?
… the dependency removing
… version used by the current dependencyId
…know the version used by the current dependencyId"
…ween removing a dependency and removing its version property.
…nt scopes, applied by different modules, should not remove the version property used by both
…DirectJavaDependency that use the version. This covers the new feature of removing unused version properties. Scenario: update the only dependency that references an existing version property. As a result, the dependency and version property will be removed. When adding the updated dependency, the version will need to be added again.
…y and AddDirectJavaDependency to ensure the version is set, avoiding unintentional exclusion.
…use it is used by another dependency management
…he version property
… from DependencyManagement
…y management with different scopes, applied by different modules, should not remove the version property used by both
…in dependency management referencing version property
…arameter Replace Collection<JavaBuildCommand> dependencyCommands with Optional<BuildProfileId> buildProfile and the instance of JavaDependencyCommandsCreator, which is sufficient to retrieve the dependencyCommands
renanfranca
force-pushed
the
6977-maven-safety-remove-property-version-when-removing-dependency
branch
from
a971a09
to
0fb6e2b
Compare
renanfranca
force-pushed
the
6977-maven-safety-remove-property-version-when-removing-dependency
branch
from
f5ca681
to
81d67df
Compare
…ependency commands Removed logic from JavaDependency.versionCommands. The logic to generate dependencyCommands is now handled in DirectJavaDependency.versionCommands and JavaDependencyManagement.versionCommands, avoiding code duplication
murdos
approved these changes
Jun 5, 2024
|
Thanks @renanfranca :) |
renanfranca
deleted the
6977-maven-safety-remove-property-version-when-removing-dependency
branch
You are welcome 😊 , thank you for the review! I am going to create an issue to handle this on Gradle 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6977