Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github should be spelled GitHub when adding CI #272

Closed
1 task done
mraible opened this issue Jan 12, 2021 · 0 comments · Fixed by #273
Closed
1 task done

Github should be spelled GitHub when adding CI #272

mraible opened this issue Jan 12, 2021 · 0 comments · Fixed by #273
Labels
Good First Issue Good as a startring point of contributions to this repo Type: Enhancement 🚀 Something that modifies or adds to existing functionality

Comments

@mraible
Copy link
Contributor

mraible commented Jan 12, 2021

Overview of the issue

I used JHipster Online to add CI (GitHub Actions) to my JHipster project. The PR it creates has a typo: Github should be GitHub.

Screen Shot 2021-01-11 at 7 13 23 PM

Motivation for or Use Case

Because I notice small things like this. ;)

Reproduce the error

Create a PR for a JHipster project using JHipster Online.

Related issues
Suggest a Fix

Change Github to GitHub.

JHipster Version(s)

Whatever version JHipster Online is using.

JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System
  • Checking this box is mandatory (this is just to show you read everything)
@SudharakaP SudharakaP transferred this issue from jhipster/generator-jhipster Jan 12, 2021
@SudharakaP SudharakaP added Good First Issue Good as a startring point of contributions to this repo Type: Enhancement 🚀 Something that modifies or adds to existing functionality labels Jan 12, 2021
SudharakaP added a commit to SudharakaP/jhipster-online that referenced this issue Jan 12, 2021
@SudharakaP
feat: add correct continous integration tool name for the pull reques…
5ffae78 
…t and commit

This corrects the name of the continous integration tool for the bot generated pull request and commit.

Resolves jhipster#272
@SudharakaP SudharakaP mentioned this issue Jan 12, 2021
Merged
SudharakaP added a commit to SudharakaP/jhipster-online that referenced this issue Jan 12, 2021
@SudharakaP
feat: add correct continous integration tool name for the pull reques…
942cd4e 
…t and commit

This corrects the name of the continous integration tool for the bot generated pull request and commit.

Resolves jhipster#272
SudharakaP added a commit that referenced this issue Jan 12, 2021
@SudharakaP
feat: add correct continous integration tool name for the pull reques…
8423ba5 
…t and commit (#273)

This corrects the name of the continous integration tool for the bot generated pull request and commit.

Resolves #272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good as a startring point of contributions to this repo Type: Enhancement 🚀 Something that modifies or adds to existing functionality
Projects
None yet
Milestone
No milestone
2 participants
@mraible @SudharakaP