-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update frontend to Angular 14 #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinedied
force-pushed
the
angular-update
branch
from
December 9, 2022 09:22
1487513
to
44730ed
Compare
@sinedied can you have a look at the merge conflict? |
sinedied
force-pushed
the
angular-update
branch
from
February 21, 2023 09:01
5d32dc4
to
daf2ac6
Compare
Merge conflict resolved ✅ |
LGTM, thanks @sinedied ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a big PR, so I'll try to summarize all the changes made and some limitations:
What has been done
Limitations
I tested the app locally with the backend and all the screens successfully, but it may need further testing on a preprod env to make sure it doesn't introduce any regression.
cc @jdubois