Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage - EntityStatColumn, CiCdToolTest, SubGenEventTypeTest #433

Merged
merged 6 commits into from Nov 7, 2023
Merged

Conversation

KaziNizamul
Copy link
Contributor

Task Description:
This PR is an attempt to increase some code coverage percentage.
I added a few test cases, which made some improvement in the code coverage i.e. 78% -> 80%.

Issue Id:
#213

Screenshots:

Earlier Now
before_change_0 1 overall_change_6

Affected Files:

  • src/main/java/io/github/jhipster/online/domain/enums/EntityStatColumnTest.java
  • src/main/java/io/github/jhipster/online/domain/enums/SubGenEventTypeTest.java
  • src/main/java/io/github/jhipster/online/service/enums/CiCdToolTest.java

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2023

CLA assistant check
All committers have signed the CLA.

@KaziNizamul
Copy link
Contributor Author

Hi @pascalgrimaud @deepu105

the CI pipeline is failing due to lint error,
but if i am running the same in IDE, its giving me no error.
Screenshot 2023-11-02 at 6 38 45 PM

I really want to contribute to this repo.
Kindly guide..

@KaziNizamul
Copy link
Contributor Author

Hi @pascalgrimaud @deepu105

the CI pipeline is failing due to lint error, but if i am running the same in IDE, its giving me no error. Screenshot 2023-11-02 at 6 38 45 PM

I really want to contribute to this repo. Kindly guide..

its resolved now ! @pascalgrimaud @deepu105
thankyou so much

@KaziNizamul
Copy link
Contributor Author

Hi @DanielFran
Can you kndly have a look at this PR please ..

@DanielFran DanielFran merged commit eec2d53 into jhipster:main Nov 7, 2023
3 checks passed
@DanielFran
Copy link
Member

Thanks @KaziNizamul for the contribution

@KaziNizamul
Copy link
Contributor Author

Thanks @KaziNizamul for the contribution

Thank you so much @DanielFran for considering this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants