Set node and yarn version in package.json engines

[jkutner]

My JHipster Registry deploys are failing with Node 10+. If there is a way to say that you want the latest LTS version of node, that would probably be better, but I don't know of such a mechanism.

I've also added a Yarn engine version to ensure it aligns with what's in pom.xml.

[jdubois]

Oh yes Node10 is a pain!

[jdubois]

Also we need Node 8+

[jkutner]

@jdubois you want "node": ">=8.2.11 <10"?

[jdubois]

Yes please

[jkutner]

@jdubois done

[PierreBesson]

@jkutner could you do a similar change on the generator ?

[pascalgrimaud]

mhhh not sure about the generator, as Node 10 will become forbidden when using JHipster.

[PierreBesson]

Well that's true but in this case the heroku subgen will be broken.

[jkutner]

@PierreBesson a fresh JHipster app created with start.jhipster.tech and then pushed to Heroku with jhipster heroku works. I'm not sure why the Registry is breaking though.

[jkutner]

@jdubois @PierreBesson i'll do whatever you decide with the generator, but can we merge this PR in advance? The "Deploy to Heroku" button is broken because Heroku tries to install Node 10.

[jdubois]

Thanks @PierreBesson for merging it.
@jkutner I hope it's good for you! I realize you don't have the commit rights, you should have them!!