This repository has been archived by the owner on Mar 21, 2021. It is now read-only.
Admin pages + specs #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Page configuration
- Health Page
- Logs Page
- Audits Page - Global components : - Pagination from BootstrapVue - JhiItemCount
- Docs API loading properties
- Gateway pages - Move admin components to ts separate files - Move tests to ts files
- Docs page
- Tracker page
- Metrics page - Fix health modal opening
sahbi-ktifa
force-pushed
the
feature/admin-pages
branch
2 times, most recently
from
28b3059
to
358f344
Compare
- User management page
sahbi-ktifa
force-pushed
the
feature/admin-pages
branch
from
358f344
to
c585ac4
Compare
|
Please someone could review this one, as it's blocking e2e tests work in progress, entity pagination, etc. I've almost finished protractor tests but I'm working on this branch right now, I would feel more comfortable if this is merged. |
|
Overall looks ok to me. I don't have time for detailed review now. If you are confident merge it as we are in WIP anyway |
|
Same comment than Deepu. |
|
Great! Thanks guys, let's move on! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add admin pages to application
Create separate ts component + specs.
Fixes #30