Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle the plugin correctly to npm #15

Closed
tvonhacht opened this issue Jan 15, 2018 · 3 comments
Closed

Bundle the plugin correctly to npm #15

tvonhacht opened this issue Jan 15, 2018 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@tvonhacht
Copy link

tvonhacht commented Jan 15, 2018 •
edited

Publishing the plugin to npm isn't bundling it correctly together? Right now its only the index.js is uploaded?
Never done this before, so have to figure out how to do this

prettier/prettier#3744
@tvonhacht tvonhacht added the help wanted Extra attention is needed label Jan 15, 2018
@azz
Copy link
Contributor

azz commented Jan 15, 2018

If you run npm pack it will create a tar file which will be the same as what is published, you can inspect the package that way. It shouldn't really be the plugins responsibility to bundle into a single file, we'll find a better way to do that.

@azz
Copy link
Contributor

azz commented Jan 15, 2018

At first glance it looks OK

https://bundle.run/prettier-plugin-java@0.0.1

@tvonhacht
Copy link
Author

Ok great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azz @tvonhacht