Skip to content

Commit

Permalink
[gndx#6] Adding documentation and problems found
Browse files Browse the repository at this point in the history
  • Loading branch information
jho3r committed Jul 10, 2022
1 parent 0ac158b commit 419d4b7
Showing 1 changed file with 31 additions and 9 deletions.
40 changes: 31 additions & 9 deletions PULL_REQUEST_TEMPLATE.md
Expand Up @@ -2,15 +2,37 @@

Solución al reto:

Nombre:
Usuario Platzi:
There were two main blocks that I found:

* The tests were giving an error message. For this one I got help from the community for a given solution to use another method for mounting the specific component for the test

* At the deployment stage, there was an error of incompatibility of react versions between two libraries, I reviewed the logs and decide to roll back to a previos version of react from 18 to 16

The API url is pointing to an endpoint of a service I have deployed in heroku.

The app is deployed to github pages, I added a file deploy.yml in the github workflows, so in every push to github the app will re-deploy.

I added an script in the index.html file for the social media icons from font awesome.
___

## Deployed app at:

https://jho3r.github.io/react-eth-challenge/
___
## Info

Nombre: Jhoer Sebastian Perez Castillo
Usuario Platzi: jho3r
Link Usuario Platzi: https://platzi.com/p/jho3r/

___

## Reto:

- [ ] Primer problema
- [ ] Segundo problema
- [ ] Tercer problema
- [ ] Cuarto Problema
- [ ] Quinto Problema
- [ ] Sexto Problema
- [ ] Septimo Problema
- [x] Primer problema
- [x] Segundo problema
- [x] Tercer problema
- [x] Cuarto Problema
- [x] Quinto Problema
- [x] Sexto Problema
- [x] Septimo Problema

0 comments on commit 419d4b7

Please sign in to comment.