Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for latest SublimeLinter and PHP CS Fixer v3.0 #13

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

gerardroche
Copy link
Contributor

Support for latest SublimeLinter (fixes #10, #11, #12)
Support for php-cs-fixer v3.0 configuration

@braver
Copy link

braver commented Nov 1, 2021

Excellent, I was just looking for this. Currently the plugin won't work on the latest SL. @jhoff do you intend to pull this PR? Otherwise I intend to pull this repo into the SublimeLinter org so that it can be maintained by the community.

@jhoff jhoff merged commit 3e88f4e into jhoff:master Nov 1, 2021
@braver
Copy link

braver commented Nov 1, 2021

@gerardroche I'm using php-cs-fixer 3.2.1 and it doesn't take --diff-format but --diff instead which outputs in udiff format.

@jhoff
Copy link
Owner

jhoff commented Nov 1, 2021

I just merged it. Not sure if there's anything else I need to do. It's been a while and I don't use sublime anymore.

Let me know if you need anything else. I'm happy to release it for community maintenance.

gerardroche added a commit to gerardroche/SublimeLinter-contrib-php-cs-fixer that referenced this pull request Nov 9, 2021
The --diff-format was removed in version 3.0, all diffs are now udiff.

https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/UPGRADE-v3.md

The --diff flag can be used to let the fixer output all the changes it
makes in udiff format.

Re jhoff#13
@gerardroche
Copy link
Contributor Author

@braver @jhoff Yes, the --diff format changed in v3, I've been using a wip fix locally for a while. PR here #14

gerardroche added a commit to gerardroche/SublimeLinter-contrib-php-cs-fixer that referenced this pull request Aug 24, 2022
The `--diff-format` was removed in v3, all diffs are now udiff.  The
`--diff flag` can be used to let the fixer output all the changes it
makes in udiff format.
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/UPGRADE-v3.md

By default the plugin is now configured for PHP-CS-Fixer V3. To enable
V2 configure the phpcsfixer linter. Open SublimeLinter settings e.g. via
the command palette *Preferences: Sublime Linter: Settings*:

```
"phpcsfixer": {
    "version": 2
}
```

Re jhoff#13
Close jhoff#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always see the status phpcsfixer(ok) and no error is highlighted
3 participants