Add flag to enable / disable logger #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jhomlala,
I added a flag in the constructor of
Catcher
to disable the description toonRecord
ofLogger
.Reason being that when someone wants to use
Catcher
and already uses theLogger
package with their ownonRecord
listener, every log message will be logged twice.Feel free to close this PR if you think it's not necessary or if you plan to address this issue in a different way ;).