Starting from scratch #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. Looks pretty good, I'll see into it this weekend! |
madmuffin1
added a commit
that referenced
this pull request
Aug 25, 2015
Lots of cleanup and refactorings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements and new features.
Including:
Multipage support;
TOC support;
Lombok dependency and unused files were removed;
README improvements;
Passing command as a String[] rather than a String to Runtime#exec, as suggested in #2;
This changes can cause incompatibility.
Please, evaluate it and if you agree, merge it. If you don't agree with some change, I can push only that things you think are good in separated way.