set nick in irc_rpl_welcome default handler #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -492,7 +492,7 @@ sub irc_nick { | |||
| my ($self, $message) = @_; | |||
| my $old_nick = ($message->{prefix} =~ /^[~&@%+]?(.*?)!/)[0] || ''; | |||
|
|
|||
| if ($old_nick eq $self->nick) { | |||
| if (lc $old_nick eq lc $self->nick) { | |||
There was a problem hiding this comment.
Also, this relaxes the nick change handler because nicks are not case sensitive. (may be needed for e.g. Twitch which lowercases your nick)
jhthorsen
pushed a commit
that referenced
this pull request
Feb 14, 2015
set nick in irc_rpl_welcome default handler
|
Cool! Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers (irc.socialgamer.net) may set a different nick on connect without using err_nicknameinuse. This handles that by setting the nick to whatever is received in irc_rpl_welcome.