PubSub retry also on deadlock #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Always log failed error message in retry when PUBSUB_DEBUG is enabled. 2. Retry when DB reports a deadlock.
jhthorsen
requested changes
Apr 10, 2023
There was a problem hiding this comment.
This change has no tests so there's no guarantee that the fix won't get reverted at a later point in time. Please add tests if you want to prevent that from happening.
I'll take the change regardless though if you want me to, since the ::PubSub class is not really a supported part of Mojo::mysql.
| if ($err =~ /^\V*(?:retry|timeout|try restart)/i) { # ... and maybe rethrow it | ||
| # If we got here, we are retrying the query: | ||
| warn qq|[PubSub] (@{[$db->pid]}) retry ($sql) !!! $err\n| if DEBUG; | ||
| } else { |
There was a problem hiding this comment.
This PR does not conform with the codestyle. Please run perltidy and force push the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After that I started seeing in debug output:
See also report about deadlock in https://jira.mariadb.org/browse/MDEV-31017