Regression tests to highlight #242 #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduce: 1. Apply this patch 2. Run: $ PERL5LIB=../json-validator/lib/:../mojo/lib:./lib prove t/v2-headers.t => FAIL: Tests fail! Weird header handling! # Failed test 'exact match for JSON Pointer "/first"' # at t/v2-headers.t line 50. # got: '42, 24, 44' # expected: '42,24, 44' # Failed test 'exact match for JSON Pointer "/second"' # at t/v2-headers.t line 50. # got: '42' # expected: '42,24, 44' # Looks like you failed 2 tests of 32. The 'first' use case, might be correct, meaning some sanitization of the collection format takes place. But the fact that the space is added even on the case that already had one, is suspicious. The second failure confirms that repeated headers are mangled in a way they get lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jhthorsen I'm not entirely sure about this regression tests, but they highlight some weird behavior. Particularly, the
firstone is adding extra spaces in suspicious ways. And the second call is stripping the trailing occurences of the header.Count on me if I can be of help.