Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve documentation #15

Closed
wants to merge 1 commit into from
Closed

improve documentation #15

wants to merge 1 commit into from

Commits on May 25, 2015

  1. improve documentation 

    This probably isn't the best message, but I think it could be really helpful to be specifically clear about this example.  I don't think it's immediately clear that the webhook URL that you specify in GitHub should not be of the same host name as one of the mounted apps.  When it is incorrectly configured this way, GitHub merely gets an unhelpful 404 response.  Of course the reason why is that the mounted app picks up on the host name specified in the Github webhook and of course that route is not configured; but this isn't necessarily obvious, nor is the solution: pick an altogether separate hostname such as prepending _ to the hostname as in http://_my_app.example.com/reload/1/2/3/4/5 or perhaps some other preferred recommendation.
    Stefan Adams committed May 25, 2015
    Configuration menu
    Copy the full SHA
    3bbf784 View commit details
    Browse the repository at this point in the history