Beta test m2l3 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: README.md 1. Numbered Lists within each section were broken due to code blocks not being nested 2. Updated `Change the source code ...` statement to specify the changes are to enable a case statement to be used, as opposed to changes to make the conditional logic to be `true` 3. For completeness, added the `.rspec` file in the file hierachy tree diagram 4. Re-ordered the bulleted list to follow the sequence of the file hierachy tree diagram 5. Added a 4th `F` to `.FFF` in the rspec code block, since there are 4 tests 6. Updated file name from case_spec to lesson1_spec in the rspec code block 7. Added another elsif clause failed example since (2) are tested with the rspec 8. Updated successful rspec code block to state 5 examples, instead of 4
Changes to be committed: modified: README.md 1. Updated file hierachy tree to specify .rspec is a hidden file
Changes to be committed: modified: ../README.md 1. Indented Code block to correct numbered list issue 2. Updated grammatical errors as part of Item2 under Technical Requirements
…solve the numbered list sequence issue 2. Updated the file hierachy diagram and associated narrative to reference the student-start directory (as done in lesson1)
JSierawski
added a commit
to JSierawski/fullstack-course1-module2
that referenced
this pull request
Jun 7, 2017
…sera#3: Classes The overall goal of this assignment is to implement a Ruby class with - class attributes, class methods, initializer methods, instance attributes, instance methods. The functional goal of the assignment is to write a Person class that will maintain state thru instance and class attributes and provide access thru instance and class class methods.
andre-lfa
pushed a commit
to andre-lfa/fullstack-course1-module2
that referenced
this pull request
Jul 17, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.md file with the following changes:
Updated the README.md file with the following changes:
the numbered list sequence issue
the student-start directory (as done in lesson1)
Note: I did not make any of these editorial / non-format changes in the HTML readme. If these changes are approved, I made the assumption that pandoc will be used to propagate the changes. Please let me know if that is a bad assumption
thanks,
Mike