Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio and Checkbox form elements #140

Open
wants to merge 7 commits into
base: refactor/front
Choose a base branch
from

Conversation

timuism
Copy link
Collaborator

@timuism timuism commented Jun 2, 2022

This PR Includes components to add refactored inputs and checkboxes to basestack.

I started using a pattern inspired from laravel, with x-components (x-checkbox, x-radio, x-fieldset). I think it may be worth using an x-component pattern on global components. I've gone back and forth on the idea so maybe we should discuss it but components like button, textarea, input, label that have a HTML tag of the same name, I like having a simple name and a simple indication that this is a component.

Also in this PR:

  • Installed tailwindcss forms plugin
  • new Checkbox and Radio components with stories for each
  • new Fieldset component with story

@timuism timuism requested a review from ahansrisuk June 2, 2022 16:15
@timuism timuism self-assigned this Jun 2, 2022
@ahansrisuk
Copy link
Collaborator

Overall looks good. The styling on these components looks great, I did not know Tailwind had a forms plugin.

I would just verify the data in the form is correct, otherwise it's good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants