Redis: Fix compatibility with node-redis v4
#5
Conversation
|
Thank you for your PR. Note that the new |
|
Wait... never mind... I think... Since we're listening for the Please give me some time to test this before merging. |
|
So, I've redesigned the Redis storage engine to the ioredis package from NPM. It is much, much better than node-redis, and I am already using it for the RedisCluster storage engine. I always intended to standardize both engines on ioredis, I just didn't have the time. This is a drop-in replacement. All you should need to do on your end is |
|
Haha I'm trying to use Redis as storage for Cronicle and ran into some
problems.
The newer `node-redis` currently has problem with return type of get/put (I
have ran test with my docker Redis and some serialization tests failed). I
don't have much time to resolve this but thanks for letting me know that.
Thank you.
…On Tue, Mar 12, 2024, 12:12 PM Joseph Huckaby ***@***.***> wrote:
So, I've redesigned the Redis storage engine to the ioredis
<https://www.npmjs.com/package/ioredis> package from NPM. It is much,
much better than node-redis, and I am already using it for the RedisCluster
storage engine. I always intended to standardize both engines on ioredis, I
just didn't have the time.
This is a drop-in replacement. All you should need to do on your end is npm
install ioredis and everything should just work.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBMVC6AESH7JKPAKOEYN7DYX2MGBAVCNFSM6AAAAABEQUH27GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQGQ4DSNZTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hmm, I've never tested Cronicle with a Redis backend, and it is not currently supported. Your mileage may vary. |
node-redisv4 has made some breaking changes (vs v3).Please see this. So, I have updated
setupmethod and added a property in README.Can you review this change? Thank you.