Fix 'permit' params to allow multiple form inputs for a single scope

[ayaman]

Resolves #114

[edwardmp]

Thanks for this, but in my case it doesn't solve the problem yet. It still complains about a unpermitted parameter.. will investigate further

[edwardmp]

Got it. The comparison is_a? Hash returns false in my case, because p is not a Hash but an instance of ActionController::Parameters (not sure why this actually deviates from your situation).

Therefore I propose the following change:
permissible_filter_params << ([ActionController::Parameters, Hash].member?(filterrific_params[p].class) ? { p => filterrific_params[p].keys } : p)

Alternatively, instead of comparing with a fixed list of classes, we could also just check if the instance responds to they keys method.

For now I'll submit a pull request to your pull request containing the former fix.

[edwardmp]

I know why it worked in your case. You must have tested on Rails 4 or earlier. Back then ActionController::Parameters inherited from hash, so the comparison to a hash evaluated to true. But starting in Rails 5 this is no longer the case and ActionController::Parameters inherits from Object instead.

Thus, what was actually passed will always be of type ActionController::Parameters. Therefore, I propose to just check that the type conforms to ActionController::Parameters, rather than checking against the Hash type. I'll modify the pull request to account for this.

More info: http://blog.bigbinary.com/2016/07/25/parameters-no-longer-inherit-from-hash-with-indifferent-access-in-rails-5.html

[ayaman]

That makes sense, thank you for the update! I merged your pull request and it seems everything is working fine.

[blaedj]

This also fixes #113 now.

[patrickworkit]

Thanks for fixing this! It would be great to have this merged in.

[edwardmp]

@jhund Could you please merge this in, as various important fixes by various contributors are included in this PR, thanks 👍

[jhund]

Thank you for the fix!