Move interactive prompt to generate access token into client #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this in a local project, configuring an access token and then using it to access my pCloud account 👍🏻 I think since I don't expect to iterate on this logic, a simple run through here is a good enough test to confirm it works for now. I can look at adding unit tests later if a regression or bug proves we need them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This resolves #12 by moving the interactive prompt to generate an access token inside of the client module. This should allow users to require the gem into a Rails console or IRB session and run
Pcloud::Client.generate_access_tokento generate the prompts.🤔 this script is currently untested in the repo, does this PR also need to include tests? I didn't change any logic but...